Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically restart backend on deps changes #1348

Merged
merged 5 commits into from
Dec 5, 2022
Merged

Automatically restart backend on deps changes #1348

merged 5 commits into from
Dec 5, 2022

Conversation

RunDevelopment
Copy link
Member

Changes:

  • The deps manager will automatically restart the backend after (un)installing dependencies.
  • Removed "Restart chaiNNer" button from deps manager.
  • Everything related to types is not allowed to assume that the schema id of a node is valid.
  • While testing, I found that the backend event source is not a good indicator to find out whether the backend is still alive. When restarting the backend, the event source sometimes errors (as in, its current state is "error"), but it actually still works just fine. So I demoted the event source error alert to a log warning.

@RunDevelopment RunDevelopment marked this pull request as ready for review December 5, 2022 17:01
@RunDevelopment
Copy link
Member Author

Invalid nodes are automatically removed now, and when the current chain has unsaved changes, we will display another warning.

I also slightly changed alerts so that these "nested" alerts aren't detected as overlapping.

@joeyballentine
Copy link
Member

Seems like when it removes the nodes it doesn't immediately remove the connected edges. I got two of these warnings
image

@RunDevelopment
Copy link
Member Author

I remove nodes via removeNodesById, so removing them likely isn't the problem. Invalid nodes don't have handles, and since they are only removed after schemata changes have been detected, RF will render one frame where the invalid nodes + edges are still present.

I don't think that there is anything I can do about that.

@joeyballentine
Copy link
Member

ok, thats fine

@joeyballentine joeyballentine merged commit 1419663 into chaiNNer-org:main Dec 5, 2022
@RunDevelopment RunDevelopment deleted the restart-backend branch December 5, 2022 23:57
@RunDevelopment RunDevelopment mentioned this pull request Dec 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeyballentine joeyballentine joeyballentine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RunDevelopment @joeyballentine